Всем привет.
У меня есть код Laravel, который на самом деле визуализирует список пользователей, которые представлены на платформе. К сожалению, этот код требует 2453 запросов для загрузки этих данных пользователю-администратору. Сегодня я покажу вам, как можно улучшить его с этого момента до 4.
Резюме
В настоящее время у меня есть этот код, который имеет следующий результат:
Event | Amount |
---|---|
Number of Queries | 2453 |
Number of Model Hydration | 7392 |
Memory Uses | 47 MB |
Processing Time | ~7 Second |
Содержание
Исследование кода К
сожалению, этот код написан не оптимизированным образом, поэтому я вижу дублирование кода, выгрузку всех записей на одной странице (без нумерации страниц) и т.д.
Вот контроллер:
public function showUsersFeatured(Request $request)
{
if ($request->segment(2) == 'unitedstates') {
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'unitedstates')->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'unitedstates')->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'unitedstates')->where('gender', '=', 'woman')->get();
$country = 'United States';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
} elseif ($request->segment(2) == 'singapore') {
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'singapore')->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'singapore')->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'singapore')->where('gender', '=', 'woman')->get();
$country = 'Singapore';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
} elseif ($request->segment(2) == 'thailand') {
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'thailand')->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'thailand')->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'thailand')->where('gender', '=', 'woman')->get();
$country = 'Thailand';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
} elseif ($request->segment(2) == 'indonesia') {
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'indonesia')->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'indonesia')->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'indonesia')->where('gender', '=', 'woman')->get();
$country = 'Indonesia';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
} elseif ($request->segment(2) == 'home') {
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('featurehome', '!=', 0)->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('featurehome', '!=', 0)->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('featurehome', '!=', 0)->where('gender', '=', 'woman')->get();
$country = 'Home';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
}
$usersfeatured = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'malaysia')->get();
$usersfeaturedman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'malaysia')->where('gender', '=', 'man')->get();
$usersfeaturedwoman = User::with(['usercity', 'tempphoto'])->where('isfeatured', '!=', 0)->where('featuredin', '=', 'malaysia')->where('gender', '=', 'woman')->get();
$country = 'Malaysia';
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $country,
]);
}
Наблюдение:
- Похожий шаблон кода
- Возврат к представлениям несколько раз
- Блок кода if-else
- Мертвый код (не используется)
Рефакторинг Я буду делать рефакторинг
шаг за шагом.
Шаг 1
: Выберите нужную страну в зависимости от вашего сегмента.
$segment = $request->segment(2);
$countries = [
'unitedstates' => ['name' => 'United States', 'featuredin' => 'unitedstates'],
'singapore' => ['name' => 'Singapore', 'featuredin' => 'singapore'],
'thailand' => ['name' => 'Thailand', 'featuredin' => 'thailand'],
'indonesia' => ['name' => 'Indonesia', 'featuredin' => 'indonesia'],
'home' => ['name' => 'Home', 'featuredin' => null, 'featurehome' => true],
'malaysia' => ['name' => 'Malaysia', 'featuredin' => 'malaysia'], // Default country
];
$countryData = $countries[$segment] ?? $countries['malaysia'];
Шаг 2
Классифицируйте обычное поведение и соберите его в одном месте.
$baseQuery = User::where('isfeatured', '!=', 0);
if (isset($countryData['featurehome'])) {
$baseQuery->where('featurehome', '!=', 0);
} else {
$baseQuery->where('featuredin', '=', $countryData['featuredin']);
}
Эти 6 строк кода на самом деле сокращают 30 строк кода и множество дублируемого кода.
Шаг 3
: Разбивка на страницы, $baseQuery
а затем использование отложенной загрузки записей отношений.
$usersfeatured = $baseQuery->paginate(50);
$usersfeatured->load(['usercity', 'tempphoto']);
$usersfeaturedman = $usersfeatured->where('gender', 'man');
$usersfeaturedwoman = $usersfeatured->where('gender', 'woman');
После этого я подал заявку на получение рекомендуемого пользователя для мужчины и женщины.
Шаг 4
Наконец, я хотел бы передать эти данные в представление.
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $countryData['name'],
]);
Полностью переработанный метод здесь:
public function index(Request $request)
{
$segment = $request->segment(2);
$countries = [
'unitedstates' => ['name' => 'United States', 'featuredin' => 'unitedstates'],
'singapore' => ['name' => 'Singapore', 'featuredin' => 'singapore'],
'thailand' => ['name' => 'Thailand', 'featuredin' => 'thailand'],
'indonesia' => ['name' => 'Indonesia', 'featuredin' => 'indonesia'],
'home' => ['name' => 'Home', 'featuredin' => null, 'featurehome' => true],
'malaysia' => ['name' => 'Malaysia', 'featuredin' => 'malaysia'], // Default country
];
$countryData = $countries[$segment] ?? $countries['malaysia'];
$baseQuery = User::where('isfeatured', '!=', 0);
if (isset($countryData['featurehome'])) {
$baseQuery->where('featurehome', '!=', 0);
} else {
$baseQuery->where('featuredin', '=', $countryData['featuredin']);
}
$usersfeatured = $baseQuery->paginate(50);
$usersfeatured->load(['usercity', 'tempphoto']); // Lazy eager load after main fetch
$usersfeaturedman = $usersfeatured->where('gender', 'man');
$usersfeaturedwoman = $usersfeatured->where('gender', 'woman');
return view('admin.featured-users.showfeatured')->with([
'usersfeatured' => $usersfeatured,
'usersfeaturedman' => $usersfeaturedman,
'usersfeaturedwoman' => $usersfeaturedwoman,
'country' => $countryData['name'],
]);
}
Шаг 5
Я также немного подправляю файл представления blade (⚠️ что не улучшает производительность).
@foreach($usersfeatured as $key => $userfeatured)
<tr class="even:bg-gray-50">
<td class="whitespace-nowrap py-4 pl-4 pr-3 text-sm font-medium text-gray-900 sm:pl-3">{{ ++$key }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->username }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->featuredsince ? $userfeatured->featuredsince->format('d M, Y') : '' }} </td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->featuredin }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->created_at->diffForHumans() }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->membershiptype }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ $userfeatured->gender }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">{{ optional($userfeatured->usercity)->currentcountry }}</td>
<td class="whitespace-nowrap px-3 py-4 text-sm text-gray-500">
@if($userfeatured->tempphoto)
<a href="" target="_blank">
<img src="{{ $userfeatured->profilePhoto() }}" alt="" width="50" height="50">
</a>
@endif
</td>
<td
class="relative whitespace-nowrap py-4 pl-3 pr-4 text-right text-sm font-medium sm:pr-3">
<a href="#" class="text-indigo-600 hover:text-indigo-900">Unfeature</a>
</td>
</tr>
@endforeach
Оценка после рефакторинга
После рефакторинга вот результат, который я нашел.
Event | Amount |
---|---|
Number of Queries | 4 |
Number of Model Hydration | 150 |
Memory Uses | 2 MB |
Processing Time | ~103 Millisecond |
Полный код
: Я создал запрос на вытягивание в github. С полным кодом можно ознакомиться здесь.
Видеоурок
Если вы визуал, а не текст, вы можете посмотреть это видео. Я всегда ценю, если у вас есть другие мысли, чтобы сделать это лучше.
Надеюсь, это решение поможет вам в будущем.
Спасибо, что прочитали.